Skip to content

Add a very basic sample app to test the SDK #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2019
Merged

Add a very basic sample app to test the SDK #19

merged 1 commit into from
Dec 10, 2019

Conversation

@mt-micky
Copy link
Contributor

@mt-micky mt-micky commented Jul 23, 2019

This is the first iteration to allow basic implementation

  • authorize (get the token)
  • go to Vault
  • go to Settings

Futures update will include triggers to enable/disable options from the SDK
A design resembling of an app, and a readme to explain how to use the sample app :)

@mt-micky mt-micky requested review from mt-max and mt-roberto July 23, 2019 06:04
@mt-micky mt-micky self-assigned this Jul 23, 2019
mt-roberto
mt-roberto reviewed Dec 5, 2019
View reviewed changes
Copy link
Contributor

@mt-roberto mt-roberto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we merge this and work from here? Anything clean up before we merge this?

@mt-roberto mt-roberto force-pushed the feat/sample_app branch 3 times, most recently from 186c224 to fe897ce Compare December 10, 2019 00:27
mt-roberto
mt-roberto previously approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@mt-roberto mt-roberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we merge this and move from here?

mt-kenny
mt-kenny reviewed Dec 10, 2019
View reviewed changes
mt-kenny
mt-kenny reviewed Dec 10, 2019
View reviewed changes
@mt-roberto mt-roberto requested a review from mt-kenny December 10, 2019 00:52
mt-roberto
mt-roberto approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@mt-roberto mt-roberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mt-roberto mt-roberto merged commit 6bbd991 into moneytree:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mt-max mt-max Awaiting requested review from mt-max

@mt-kenny mt-kenny Awaiting requested review from mt-kenny

1 more reviewer

@mt-roberto mt-roberto mt-roberto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mt-micky mt-micky

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mt-micky @mt-roberto @mt-kenny